Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Summary): Filter departments to PRD and also send report to delegated responsibles #675

Merged
merged 9 commits into from
Aug 29, 2024

Conversation

Jonathanio123
Copy link
Collaborator

@Jonathanio123 Jonathanio123 commented Aug 20, 2024

  • New feature
  • Bug fix
  • High impact

Description of work:

Renamed functions.

Now only takes PRD departmens like the old function did.

The Departments model has been reworked and now has a field for Resource owners and Delegated resource owners. This required refactoring of a lot of code.

For now they're separated into two properties but could be merged into a single recipients list instead,

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@Jonathanio123 Jonathanio123 marked this pull request as ready for review August 21, 2024 13:47
@Jonathanio123 Jonathanio123 requested a review from larfeq August 21, 2024 13:47
# Conflicts:
#	src/Fusion.Summary.Functions/Deployment/disabled-functions.json
@Jonathanio123 Jonathanio123 requested a review from larfeq August 28, 2024 14:08
@Jonathanio123 Jonathanio123 changed the title chore: Filter departments to PRD and also send report to delegated responsibles chore(Summary): Filter departments to PRD and also send report to delegated responsibles Aug 29, 2024
@Jonathanio123 Jonathanio123 merged commit 07dfef0 into master Aug 29, 2024
13 checks passed
@Jonathanio123 Jonathanio123 deleted the chore/summary/adjust-recipients branch August 29, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants